chore: masking at the top of the trace#22334
Open
iakovenkos wants to merge 42 commits intomerge-train/barretenbergfrom
Open
chore: masking at the top of the trace#22334iakovenkos wants to merge 42 commits intomerge-train/barretenbergfrom
iakovenkos wants to merge 42 commits intomerge-train/barretenbergfrom
Conversation
…ay from RDP
With top-of-trace masking, the row-disabling polynomial 1 - ∏_{i≥2}(1-u_i)
is circuit-size independent. The verifier evaluates it over ALL D challenges
without needing log_circuit_size or padding_indicator_array.
Prover: ZK virtual rounds now use compute_virtual_contribution * (1-L) + libra
instead of sending zero univariates. Libra univariates cover all D rounds.
Verifier: apply_zk_corrections evaluates RDP from challenge vector size.
compute_padding_indicator_array returns all-1s (unified path).
iakovenkos
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
…i/eccvm-lagrange-last-integer
…i/eccvm-lagrange-last-integer
3 tasks
notnotraju
added a commit
that referenced
this pull request
Apr 10, 2026
…22461) ## Summary Add `lagrange_first * transcript_accumulator_not_empty = 0` subrelation to `ECCVMTranscriptRelation`. This is a prerequisite for #22334 (masking at top of ECCVM circuit). The audit in #22442 identified that when `lagrange_first` moves to row k (away from the PCS-enforced zero row), `transcript_accumulator_not_empty` is the only shiftable column where a malicious prover can potentially set a non-zero value at the `lagrange_first` row without any existing relation catching it. Setting it to 1 disables `INFINITY_ACC_X/Y`, allowing arbitrary accumulator coordinates to be injected. ## Changes - New subrelation `ACCUMULATOR_NOT_EMPTY_INIT` in `ecc_transcript_relation.hpp` (degree 2) - Gate count updates (+174 gates from the new subrelation): - `ECCVM_RECURSIVE_VERIFIER_GATE_COUNT`: 224336 → 224510 - `CHONK_RECURSION_GATES`: 1491593 → 1491767 ## Test plan - [x] `eccvm_tests` — all 44 tests pass - [x] `stdlib_eccvm_verifier_tests` — `SingleRecursiveVerification` passes with updated gate count - [x] `dsl_tests` — `GateCountChonkRecursion` passes with updated gate count Co-authored-by: notnotraju <raju@aztec-labs.com>
…i/eccvm-lagrange-last-integer
…i/eccvm-lagrange-last-integer
iakovenkos
commented
Apr 13, 2026
| // Override VIRTUAL_LOG_N for the AVM recursive verifier circuit | ||
| static constexpr size_t VIRTUAL_LOG_N = MEGA_AVM_LOG_N; | ||
|
|
||
| // AVM doesn't use ZK masking, so no disabled rows are needed. Setting TRACE_OFFSET=0 |
Contributor
Author
There was a problem hiding this comment.
It's annoying but seems like the only way to keep TwoLayerAVMRecursiveVerifier intact without introducing an extra merge. The reason is that mega by default would commit to ecc op wires as [0, 0, 0, 0, *] and pass those directly to Translator, that operates on the op queue without the zeroes. in chonk, merge takes care of unshifting the final table, in avm we use the old layout of mega circuits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.